Allow B-frames

[Bleuzen]

Removes the B-frame limitation. These were force-disabled before.

Tested in firefox, chromium and edge with both h264 and av1. All played fine with bframes, just needs a larger jitter buffer if using many of them.

[sourcery-ai]

Sorry @Bleuzen, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[coderabbitai]

Walkthrough

This change removes the forced setting of the video encoder "bf" (B-frames) parameter to 0 in two locations: MoQDock::CreateConfiguredEncoders in src/moq-dock.cpp and MoqService::ApplyEncoderSettings in src/moq-service.cpp. The "repeat_headers" = true setting for MoQ's inline header formats remains unchanged in both locations. An associated comment describing the "bf" behavior was also removed.

Changes

File	Change Summary
src/moq-dock.cpp	Removed "bf" = 0 setting and its comment; retained "repeat_headers" = true
src/moq-service.cpp	Removed "bf" = 0 setting; retained "repeat_headers" = true

Sequence Diagram(s)

Not applicable — this change involves removal of a configuration parameter with no observable control flow to diagram.

Estimated code review effort: 1 (Low)

Related issues: None provided

Related PRs: None provided

Suggested labels: encoder, cleanup

Suggested reviewers: None provided

Poem:
A rabbit hopped through encoder code,
Found "bf" = 0 along the road,
Snipped it clean without a fuss,
"repeat_headers" stayed, no need to discuss.
Two files lighter, the settings flow—
Hop away now, off we go! 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Accurately summarizes the main change: the PR removes the forced B-frame disablement.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The description clearly matches the change to stop forcing B-frames off and mentions relevant playback testing.

✨ Finishing Touches

✨ Simplify code

• Create PR with simplified code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

src/moq-dock.cpp (1)

219-220: 🧹 Nitpick | 🔵 Trivial

Consider surfacing jitter buffer sizing implications.

The PR description notes that using many B-frames may require a larger jitter buffer to perform comparably to non-B-frame streams. Since this file/segment doesn't touch buffer sizing, worth confirming elsewhere in the stack (e.g., MoQ output/dock buffer config) that jitter buffer size is either adaptive or exposed for users to tune when they opt into more aggressive B-frame settings.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/moq-dock.cpp` around lines 219 - 220, The MoQ inline-headers change in
moq-dock.cpp only forces repeat_headers and does not address the stated B-frame
jitter-buffer impact. Review the MoQ output/dock configuration path around the
related buffer-sizing settings and make sure jitter buffer size is either
adaptive to B-frame-heavy streams or exposed as a user-tunable option. Use the
existing MoQ dock/output setup symbols near the repeat_headers handling to
locate where the buffer config should be added or wired through.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/moq-dock.cpp`:
- Around line 219-220: The MoQ inline-headers change in moq-dock.cpp only forces
repeat_headers and does not address the stated B-frame jitter-buffer impact.
Review the MoQ output/dock configuration path around the related buffer-sizing
settings and make sure jitter buffer size is either adaptive to B-frame-heavy
streams or exposed as a user-tunable option. Use the existing MoQ dock/output
setup symbols near the repeat_headers handling to locate where the buffer config
should be added or wired through.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 49b62ddd-6c75-40b1-96d6-d90e4f8c8254

📥 Commits

Reviewing files that changed from the base of the PR and between 323d597 and d956e91.

📒 Files selected for processing (2)

• src/moq-dock.cpp
• src/moq-service.cpp

💤 Files with no reviewable changes (1)

• src/moq-service.cpp