Expose remote cache read errors and fail on server disconnects - #2779
Expose remote cache read errors and fail on server disconnects#2779seungpyoson wants to merge 1 commit into
Conversation
e14c22c to
5abf492
Compare
5abf492 to
83b66fd
Compare
83b66fd to
a35fe90
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
+ Coverage 70.90% 70.94% +0.03%
==========================================
Files 71 71
Lines 40393 40414 +21
==========================================
+ Hits 28642 28673 +31
+ Misses 11751 11741 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 45.99%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | lru_sequential_scan_pattern |
128 B | 260 B | -50.77% |
| ❌ | Memory | lru_hotcold_access_pattern |
128 B | 260 B | -50.77% |
| ❌ | Memory | hash_multiple_files |
128 B | 260 B | -50.77% |
| ❌ | Memory | time_macro_finder_chunked |
128 B | 260 B | -50.77% |
| ❌ | Memory | lru_cache_get_hit |
128 B | 260 B | -50.77% |
| ❌ | Memory | hash_large_data |
192 B | 324 B | -40.74% |
| ❌ | Memory | hash_header_file |
192 B | 324 B | -40.74% |
| ❌ | Memory | cache_key_generation |
192 B | 324 B | -40.74% |
| ❌ | Memory | time_macro_finder_with_macros |
192 B | 324 B | -40.74% |
| ❌ | Memory | time_macro_finder_no_macros |
192 B | 324 B | -40.74% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing seungpyoson:agent/fail-closed-cache-errors (a35fe90) with main (7cd4f2c)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Summary
NotFoundremote read failures through the existing cache-error statistics path instead of counting them as ordinary missesCompileStartedresponse I/O failures follow the documented default-fatal policy while preservingSCCACHE_IGNORE_SERVER_IO_ERROR=1Deliberately unchanged
Scope
One commit changes
src/cache/cache.rsandsrc/commands.rsonly. There are no documentation, protocol, cache-format, dependency, disk-cache, multi-level-cache, or client-side-storage changes. Existing documentation already describes the server-I/O policy.Validation
Focused regression tests cover unexpected direct remote read errors, default-fatal post-start disconnects, and the existing opt-in local fallback. Upstream CI and maintainer review remain required before merge.