Add may_dangle Drop impl under the unstable flag - #91
Merged
Conversation
Contributor
Author
|
That was quick, thanks a lot! Do you have a plan to release the new version anytime soon? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use ThinVec quite a bit in the compiler, but there are cases where we can't, because it doesn't have
#[may_dangle]onT. This is a case I recently encountered for example: https://github.com/rust-lang/rust/blob/ae3bbe78ec2a9bb57a03f10ad6ee0388e12bcefb/compiler/rustc_middle/src/mir/statement.rs#L1041This PR adds the Drop impl under the existing
unstablefeature flag. I moved the cold drop function out of it to avoid duplicating too much code.I followed a similar pattern as in servo/rust-smallvec#133, which did the same for smallvec (motivated by the compiler, too)