Remove standalone programs lua.c and luac.c (move to lua370-app)#4
Merged
Conversation
LUA and LUAC are standalone programs, not library code. They are being moved to the new lua370-app project. This makes lua370 a pure library and eliminates IEW0241 doubly-defined warnings for embedders. Closes #3
mgrossmann
added a commit
that referenced
this pull request
Jun 30, 2026
lctype.c was never carried in the repo, so the Lua ctype table luai_ctype_ (asm label LUAI0001, declared in lctype.h) was never defined. It went unnoticed because lua370 has only been built as a library (incomplete archives tolerate undefined symbols) and never fully linked since the standalone lua.c/luac.c were removed (#4). The first real consumer doing a full link (httplua) exposed it. Restore the standard Lua 5.4 lctype.c so the archive is self-contained. Refs #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Changes
src/lua.cremovedsrc/luac.cremovedNotes
No build config changes needed.
project.tomlstays as-is (typelibrary, no link section).After merge: release v1.0.1 — first version without standalone modules. The new
lua370-appproject will depend onlua370 >=1.0.1.