[sdk] F: Use required build image type#329
Merged
Merged
Conversation
Remove the unreachable optional guard now that canonical SDK manifests are mandatory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a354ddf-0f65-44b2-a2cb-81d4662a3587
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the SDK build-image selection logic in the Nanvix Python build script by removing a now-unreachable None guard for the SDK Docker image reference (per the updated zutils behavior noted in the PR description).
Changes:
- Removed the
sdk_image is Nonefatal guard before invokingdocker runfor bytecode precompilation.
Show a summary per file
| File | Description |
|---|---|
| .nanvix/src/build.py | Removes an unreachable validation branch and relies on the toolchain’s required SDK build image reference when running the SDK container. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unreachable optional SDK image guard under zutils v0.16.1. Pyright and Black pass.