[sdk] E: Remove duplicate image pin#306
Merged
Merged
Conversation
Use the canonical manifest as the only SDK image source. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a354ddf-0f65-44b2-a2cb-81d4662a3587
There was a problem hiding this comment.
Pull request overview
This PR removes a repository-local, hard-pinned Nanvix SDK Docker image override and updates the Nanvix build documentation to rely on the canonical SDK/toolchain pin in the Nanvix manifest instead.
Changes:
- Removed the
NANVIX_DOCKER_IMAGEconstant and theSqliteBuild.docker_image()override from.nanvix/z.py. - Updated
.nanvix/NANVIX.mdto stop passing an explicit image digest to./z setupand to reference.nanvix/nanvix.tomlas the canonical source for the SDK pin.
Show a summary per file
| File | Description |
|---|---|
.nanvix/z.py |
Drops the redundant per-repo SDK image pin/override so the build relies on the canonical toolchain configuration. |
.nanvix/NANVIX.md |
Updates build instructions to use ./z setup without an explicit SDK image and points readers to the canonical manifest. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dead z.py image override and replace explicit setup coordinates with the canonical manifest. Lint and strict typing pass.