fix(store-update): decode packed MSIX version to stop perpetual update nag#119
Merged
Conversation
…e nag
The DisplayCatalog API can report the package version as a packed
UInt64 PackageVersion (e.g. 281535106252800 for 1.14.0.0) instead of a
dotted string. The old code read it raw, so it both displayed the giant
integer ("PDFApps 281535106252800 is available") and compared it as a
gigantic major version, making the Store always look newer than the
installed build — an update dialog on every launch even when already
up to date.
Add _decode_packed_version / _normalize_store_version / _format_version:
normalise every Store version (packed int, packed string, or dotted
string) to a semantic (major, minor, build, revision) tuple, comparing
apples to apples and displaying a canonical readable string. Corrupt or
out-of-range values normalise to None so we fail safe (no notification).
The per-version dismiss key now stores the decoded canonical version,
consistent with the existing i18n UInt16 validation.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add the v1.14.1 release entry to the top of the changelog and move the "Latest" badge from v1.14.0 to v1.14.1, leaving v1.14.0 intact below it. The 1.14.1 entry describes the Microsoft Store update-notification fix in user-facing terms. Adding the new heading and moving the badge is the editorial step the release workflow no longer performs: the version bump is anchored to the footer changelog link only, so historical headings are never rewritten. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying pdfapps with
|
| Latest commit: |
46168bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f3292bc.pdfapps.pages.dev |
| Branch Preview URL: | https://fix-store-update-packed-vers.pdfapps.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
After updating to 1.14.0 via the Microsoft Store, the app kept showing "PDFApps 281535106252800 is available" perpetually, even though the installed version was already the latest.
Cause
The DisplayCatalog API returns the package version as a packed UInt64 (
281535106252800=1.14.0.0). The updater displayed the raw integer and compared it against the installed semantic version, so the Store version always looked "newer" — an infinite update nag.Fix
major/minor/build/revisioncomponents.Tests
store_updatertests (55 passed).ruff/mypyclean.Ref: 3a0319f