fix(cli): space-form subcommands error instead of fake-succeeding; did-you-mean for flags#8332
Open
DavidWells wants to merge 1 commit into
Open
fix(cli): space-form subcommands error instead of fake-succeeding; did-you-mean for flags#8332DavidWells wants to merge 1 commit into
DavidWells wants to merge 1 commit into
Conversation
…exit 0 'netlify sites delete my-site' used to print the sites help text and exit 0 - a false success for any script. Namespace commands now exit 2 with a colon-form did-you-mean that preserves the remaining args. Typo'd flags also get did-you-mean suggestions, and root-level unknown flags name the subcommands that own them.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #8300 (4 of 9). Stacked on #8329 — merge that first; GitHub will retarget this to
main.What
netlify sites delete my-precious-siteused to print thesiteshelp text and exit 0. Now:(exit 2, stderr — flags/args are preserved in the suggestion, so
netlify env list --jsonsuggestsnetlify env:list --json)Also: typo'd flags get did-you-mean suggestions, and unknown root-level flags name the commands that own them (
netlify --jsno→'--json' is a flag of: env:list, status, ...).Why it helps agents
This was the most dangerous false-success in the CLI: a script or agent doing cleanup reads exit 0 as "site deleted" when nothing happened. Exit 0 now always means the command actually ran, and the error names the exact corrected command so an agent self-corrects in one step.
Testing