Skip to content

feat(status): --json always emits a JSON object for every auth/link state#8335

Open
DavidWells wants to merge 1 commit into
mainfrom
split/status-json
Open

feat(status): --json always emits a JSON object for every auth/link state#8335
DavidWells wants to merge 1 commit into
mainfrom
split/status-json

Conversation

@DavidWells

Copy link
Copy Markdown
Contributor

Split from #8300 (7 of 9).

What

netlify status --json emitted zero bytes of stdout when logged out or unlinked (exit 1 with no explanation of which). Now every state emits a JSON object:

{
  "loggedIn": true,
  "linked": false,
  "account": { "Name": "", "Email": "" },
  "siteData": null,
  "error": { "code": "NOT_LINKED", "fix": "netlify link" }
}

Codes: NOT_LOGGED_IN (no token or expired session), NOT_LINKED. The success payload gains additive loggedIn/linked/error: null fields. Non-JSON output and exit semantics are unchanged.

Why it helps agents

status --json is the first command an agent runs to orient itself. Zero-byte stdout forces guessing between "not logged in" and "not linked"; a stable error.code + fix makes recovery a single deterministic step, and JSON.parse(stdout) never throws.

Testing

  • New unit tests covering all four states (logged out, expired session, unlinked, linked)
  • typecheck ✓ lint ✓ 412 unit tests ✓

…tate

status --json emitted zero bytes of stdout when logged out or unlinked.
Every state now produces a JSON object with loggedIn/linked booleans
and a stable error code (NOT_LOGGED_IN, NOT_LINKED) plus suggested fix.
Success payload gains additive loggedIn/linked/error fields.
@DavidWells DavidWells requested a review from a team as a code owner July 6, 2026 18:00
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@DavidWells, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1fbf06c9-8a2b-4b29-b780-05f1851371e8

📥 Commits

Reviewing files that changed from the base of the PR and between 3c41e72 and 126f1f6.

📒 Files selected for processing (2)
  • src/commands/status/status.ts
  • tests/unit/commands/status/status.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch split/status-json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

📊 Benchmark results

Comparing with 3c41e72

  • Dependency count: 1,127 (no change)
  • Package size: 379 MB ⬇️ 0.00% decrease vs. 3c41e72
  • Number of ts-expect-error directives: 359 (no change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant