fix(user): allow GitHub-only accounts to edit profile without a password#1807
Merged
Conversation
edward-ly
approved these changes
Jul 11, 2026
Collaborator
There was a problem hiding this comment.
While I don't think it's possible to test this in a local environment, the code makes sense. For a low impact change such as this, I think it's still fine to push this to production and try it out once it's deployed there.
And one small note, I added a # nosec in one of the user tests to suppress a false positive coming from Bandit.
edward-ly
force-pushed
the
fix/github-account-password-required
branch
from
86d6b89 to
9d7b650
Compare
AccountForm unconditionally required a confirmation password when changing name/email, but accounts created via GitHub OAuth have no usable password to confirm, so those edits always failed. Skip the password requirement/check when the account has no usable password. Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
fix/github-account-password-required
branch
from
9d7b650 to
b1c97ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountFormunconditionally required a confirmation password when changing name/email/subscribe_to_news, but accounts created via GitHub OAuth have no usable password to confirm — so those edits always failed with "Password is required to change these fields."has_usable_password()before requiring/validating the confirmation password. This is more general than special-casing thegithubprovider (mirrors the approachDeleteAccountFormalready uses for GitHub, but covers any social-only login).Test plan
GitHubOnlyAccountEditTestcovering name and email changes for a GitHub-only (no usable password) accountpoetry run python manage.py test nextcloudappstore.user.tests --settings nextcloudappstore.settings.development— all 15 tests pass🤖 Generated with Claude Code