fix(post-message): verify incoming and outgoing origin#5874
Merged
Conversation
elzody
added
the
4. to release
rikled
approved these changes
Jul 17, 2026
3 tasks
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
force-pushed
the
fix/postmessage-origin
branch
from
July 23, 2026 16:00
5e58bf2 to
04c9ad6
Compare
In the Cypress container, the incorrect Collabora URL is used which causes the origin validation to fail Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Collaborator
Author
|
/backport to stable34 please |
Collaborator
Author
|
/backport to stable33 please |
Collaborator
Author
|
/backport to stable32 please |
Collaborator
Author
|
/backport to stable31 please |
Collaborator
Author
|
/backport to stable30 please |
Collaborator
Author
|
/backport to stable29 please |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/5874/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 04c9ad64 7b25afad
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5874/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jul 23, 2026
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post messages sent between Nextcloud and Collabora never actually had their origins verified, so now we verify those origins to make sure they cannot be acted upon from an untrusted origin.
Checklist