Skip to content

Ignore linting the .build/ai directory #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aluqmanj-ni wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Draft

Ignore linting the .build/ai directory #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ni_python_styleguide/config.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ per-file-ignores=
tests/**/test_*.py,tests/test_*.py:D100,D103,D102
# We don't need to document every Sphinx config
docs/conf.py:D1
# We don't need to document AI scripts
.build/ai/**:D1

@mshafer-NI mshafer-NI Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to do this. If it gets checked into source, it should be documented.

@bkeryan bkeryan Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does nps honor .gitignore? is this "AI" stuff typically in .gitignore?

@aluqmanj-ni aluqmanj-ni Jul 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this "AI" stuff typically in .gitignore?

Yes, the .build dir is in .gitignore

I've created another PR to update our skills to create AI scripts in <repo-root>/.build/ai directory. If that change is approved, this will not be required.

@bkeryan bkeryan Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nps doesn't honor .gitignore, updating it to do so would benefit human developers too.

@mshafer-NI mshafer-NI Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not. And while that may be useful, we should include a config option to explicitly include dirs / patterns if we choose to add that.

@bkeryan bkeryan Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do other linters do?

# __init__.py files routinely import other modules without directly using them
__init__.py:F401

Expand Down
Loading