fix(wpf): make navigation lifecycle-safe - #8
Draft
nicolasestrem wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The WPF shell could trap users in Compare, hide an active progress workspace behind Settings or About, and terminate a running operation when the sole window closed. Advanced history also existed without a route and performed its catalog read on the UI thread.
Impact
Navigation now preserves operation visibility and comparison ownership. The active-run close guard prevents accidental termination while keeping normal close behavior unchanged. Advanced history is reachable without blocking rendering on catalog I/O.
This is a stacked draft based on
feat/wpf-timeline-shelland should be reviewed after PR #7. It does not merge or modify PR #7.Validation
dotnet build src\WinRestoreKit.Tests\WinRestoreKit.Tests.csproj -c CodexVerify: 0 warnings, 0 errorsdotnet test src\WinRestoreKit.Tests\WinRestoreKit.Tests.csproj -c CodexVerify --no-build: 990 passed, 0 faileddotnet format ... --verify-no-changes --include <changed C# files>: 0 files require formattingThe isolated
CodexVerifyconfiguration was used because the user's active Debug session intentionally remained running and retained its executable lock.