feat(keybind-cheatsheet): update to v0.2.2 data service architecture and bug fixes - #370
Closed
cheerfulScumbag wants to merge 2 commits into
Closed
Conversation
Contributor
|
This pull request was automatically closed because its description no longer contains Missing:
Please add the items listed above back to the description, keeping their exact wording, then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
kenn/keybind-cheatsheetplugin.toml)What it does
This update introduces a major architectural refactor to resolve host CPU callback timeouts and fixes reported community issues:
Data Service Architecture (
service.luau):[[service]] id = "data").panel.luau) is now instant (0ms) and renders pre-parsed snapshots from memory without performing synchronous file I/O.Bug Fixes:
onOpen()callback CPU budget timeout that caused blank panels on startup. Added support for single-quotedincludedirectives (include './path.kdl').extractLuaStringLiterals) to properly assign categories for empty string prefix concatenations ("" .. "Bar"), multiline assignments, and concatenated descriptions.resetCallbacks()) inpanel.luauon panel close and plugin exit.Metadata & API:
plugin_api = 9for Noctalia v5 compatibility.Note for @rylos: Once this v0.2.2 release is merged, PR #333 can rebase on top of this clean baseline to add your Niri 3x parsing speedup and 15s refresh timeout recovery!
External dependencies
hyprctl(used only for Hyprland Lua live bind queries)Testing
Screenshots / Videos
No visual changes to the UI surface. Rendered keybinding layout remains identical to v0.2.1.
Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
licensedeclared inplugin.toml.