fix(escapeTitle): different RegEx#242
Open
avivkeller wants to merge 2 commits into
Open
Conversation
Co-Authored-By: aduh95 <aduh95@noreply.users.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the escapeTitle() implementation used when rendering agenda issue titles into templates/meeting.mustache, aiming to change how square brackets are escaped so markdown link rendering isn’t broken by bracket characters in GitHub issue titles.
Changes:
- Replaced the
escapeTitle()escaping logic with a new regular expression intended to handle bracket escaping differently.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+60
| const escapeTitle = title => | ||
| title.replace(/\\/g, '\\\\').replace(/([\[\]])/g, '\\$1'); | ||
| title.replace(/(?<!\\)(?:\\\\)*([[\]])/g, '\\$1'); |
| */ | ||
| const escapeTitle = title => | ||
| title.replace(/\\/g, '\\\\').replace(/([\[\]])/g, '\\$1'); | ||
| title.replace(/(?<!\\)(?:\\\\)*([[\]])/g, '\\$1'); |
aduh95
reviewed
Jul 1, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
| */ | ||
| const escapeTitle = title => | ||
| title.replace(/\\/g, '\\\\').replace(/([\[\]])/g, '\\$1'); | ||
| title.replace(/(?<!\\)(\\\\)*([[\]])/g, '$1\\$2'); |
aduh95
approved these changes
Jul 1, 2026
aduh95
left a comment
aduh95
left a comment
Contributor
There was a problem hiding this comment.
Adding more tests sounds good if the robot wants to write them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't personally see the difference between these two RegExps, but if @aduh95 thinks it's better, then it's probably better :-)