fs: fix for FileHandle.readableWebStream

[pdaehne]

Fixes FileHandle.readableWebStream in mode "byob" when reading into a view that has a byteOffset>0 into the underlying ArrayBuffer.

Fixes: #58817

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67665/

[mertcanaltin]

LGTM, but I think we need to edit the return byteofset field in cpp to solve this problem, I wonder if I am thinking wrong here

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (41525ab) to head (8303a83).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58842      +/-   ##
==========================================
- Coverage   90.16%   90.14%   -0.02%     
==========================================
  Files         746      746              
  Lines      242660   242660              
  Branches    45720    45722       +2     
==========================================
- Hits       218793   218756      -37     
- Misses      15360    15406      +46     
+ Partials     8507     8498       -9     

Files with missing lines	Coverage Δ
lib/internal/fs/promises.js	93.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pdaehne]

@mertcanaltin Have a look at this example in the Streams specification, it is more or less a copy of the code in Node.js, and they also use 0 as the "offset" parameter for "FileHandle.read()":

https://streams.spec.whatwg.org/#example-rbs-pull

[mertcanaltin]

@mertcanaltin Have a look at this example in the Streams specification, it is more or less a copy of the code in Node.js, and they also use 0 as the "offset" parameter for "FileHandle.read()":

thanks!

[LiviaMedeiros]

LGTM, thanks for fixing this!

The correct subsystem (prefix in the commit message) should be fs:, this also can be adjusted by a collaborator who lands it.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67998/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68029/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68034/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68041/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68095/

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/68095/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/30049898777

[Ethan-Arrowood]

This needs rebased on main if we want CI to start

[trivikr]

@pdaehne Can you please sign the first commit and force push?

It's required as per updated instructions

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin