Skip to content

doc: remove usage of util.inherits - #60817

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
AugustinMauroy:remove-util.inherits
Aug 7, 2026
Merged

doc: remove usage of util.inherits#60817
aduh95 merged 1 commit into
nodejs:mainfrom
AugustinMauroy:remove-util.inherits

Conversation

@AugustinMauroy

@AugustinMauroy AugustinMauroy commented Nov 22, 2025

Copy link
Copy Markdown
Member

Description

  • Removing legacy api mention in doc
  • Removing Legacy api usage in test I just found it by doing a search for mention of it

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 22, 2025
@codecov

codecov Bot commented Nov 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (93c2581) to head (100af7f).
⚠️ Report is 874 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60817      +/-   ##
==========================================
+ Coverage   88.43%   88.55%   +0.11%     
==========================================
  Files         703      703              
  Lines      208235   208254      +19     
  Branches    40085    40159      +74     
==========================================
+ Hits       184162   184424     +262     
+ Misses      16069    15828     -241     
+ Partials     8004     8002       -2

see 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95

aduh95 commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

The doc part LGTM, can you remove the test change? IMO we want to validate there are no regressions on legacy APIs

@AugustinMauroy

AugustinMauroy commented Nov 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

There are a specific test for this api. I had checked that . (I am on mobile I can't give the name of the test file)

EDIT: file is test-util-inherits.js

@aduh95

aduh95 commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

I would still prefer the test change gets to be discussed separately

@aduh95

aduh95 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

@AugustinMauroy can you please split the PR as requested?

@AugustinMauroy

AugustinMauroy commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

@AugustinMauroy can you please split the PR as requested?

I'm going to do that. kind of busy

@AugustinMauroy
AugustinMauroy force-pushed the remove-util.inherits branch from 100af7f to f3cce25 Compare May 7, 2026 17:10
@AugustinMauroy AugustinMauroy changed the title doc,test: remove usage of util.inherits doc: remove usage of util.inherits May 7, 2026
@AugustinMauroy

AugustinMauroy commented May 7, 2026

Copy link
Copy Markdown
Member Author

yup done x'D

@AugustinMauroy
AugustinMauroy force-pushed the remove-util.inherits branch from f3cce25 to c3bdd0d Compare May 7, 2026 20:11
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale label Aug 6, 2026
@AugustinMauroy

AugustinMauroy commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

not stale

@AugustinMauroy @aduh95
doc: remove usage of util.inherits
cb31667 
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
@aduh95
aduh95 force-pushed the remove-util.inherits branch from c3bdd0d to cb31667 Compare August 6, 2026 22:19
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 6, 2026
@aduh95 aduh95 closed this Aug 6, 2026
@aduh95 aduh95 reopened this Aug 6, 2026
@github-actions github-actions Bot removed the stale label Aug 7, 2026
@aduh95 aduh95 closed this Aug 7, 2026
@aduh95 aduh95 reopened this Aug 7, 2026
@aduh95 aduh95 added doc Issues and PRs related to the documentations. and removed needs-ci PRs that need a full CI run. labels Aug 7, 2026
@aduh95
aduh95 merged commit e43bedc into nodejs:main Aug 7, 2026
18 checks passed
@aduh95

aduh95 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Landed in e43bedc

aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@AugustinMauroy @aduh95
doc: remove usage of util.inherits
96b764c 
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
PR-URL: #60817
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AugustinMauroy @aduh95 @anonrig @aymen94 @nodejs-github-bot