v8: avoid V8 worker hang during platform shutdown - #64283
Closed
Archkon wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
c++
Member
|
@nodejs/v8 |
Member
|
Same comment as on #64268 -- this would heavily benefit from a commit message that explains the what, how and why of the change |
Node could hang during shutdown while joining V8 worker threads if a worker was parked waiting for foreground GC work. This can happen when a V8 background task requests GC from the main isolate thread during process exit, after Node has stopped processing foreground tasks but before the platform worker pool is joined. Flush foreground tasks for registered Node isolates before shutting down the worker task runner so pending GC work can run and release parked workers. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Member
|
And tests :-) |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64274