stream: reject nested async streamables in from()#64352
Open
trivikr wants to merge 1 commit into
Open
Conversation
Reject nested async iterables and toAsyncStreamable values when from() is consuming a sync iterable source. Promise values are still awaited. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64352 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 741 741
Lines 240979 240988 +9
Branches 45395 45409 +14
=======================================
+ Hits 217450 217464 +14
Misses 15112 15112
+ Partials 8417 8412 -5
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 8, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64351
This updates
stream/iter.from()so the sync-iterable fallback rejectsnested async-only streamables. When
from()consumes a sync iterable, nestedasync iterables and
toAsyncStreamablevalues now throwERR_INVALID_ARG_TYPEinstead of being consumed.Promise values yielded by sync iterables are still awaited.
Assisted-by: openai:gpt-5.5