fs: fix cp symlink and EEXIST handling on Windows#64353
Open
PickBas wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#59636 Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64353 +/- ##
==========================================
- Coverage 92.01% 90.24% -1.77%
==========================================
Files 379 741 +362
Lines 166972 240984 +74012
Branches 25554 45398 +19844
==========================================
+ Hits 153639 217476 +63837
- Misses 13041 15069 +2028
- Partials 292 8439 +8147
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs: fix cp symlink and EEXIST handling on Windows
On Windows,
fs.cp/fs.cpSynchad two bugs:std::filesystemcarried the\\?\extended-length prefix, breaking path comparison and symlink targets. Now stripped.EEXISTcheck used the raw POSIX value, which never matched on Windows. Now compares againststd::errc::file_exists.Re-enables 2 tests that were skipped for this issue.
Fixes: #59636