deps: float ICU-23262 patch for icu78 - #64678
Merged
Merged
Conversation
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
ovflowd
approved these changes
Aug 11, 2026
ovflowd
left a comment
Member
There was a problem hiding this comment.
Having a temporary patch for this sounds good.
Collaborator
jasnell
approved these changes
Aug 11, 2026
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64678 ✔ Done loading data for nodejs/node/pull/64678 ----------------------------------- PR info ------------------------------------ Title deps: float ICU-23262 patch for icu78 (#64678) Author René <contact.9a5d6388@renegade334.me.uk> (@Renegade334) Branch Renegade334:icu78-iso8601-dates -> nodejs:main Labels tools, i18n-api, needs-ci, review wanted, commit-queue, icu, lts-watch-v24.x Commits 1 - deps: float ICU-23262 patch for icu78 Committers 1 - Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: https://github.com/nodejs/node/pull/64678 Fixes: https://github.com/nodejs/node/issues/63041 Refs: https://unicode-org.atlassian.net/browse/ICU-23262 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64678 Fixes: https://github.com/nodejs/node/issues/63041 Refs: https://unicode-org.atlassian.net/browse/ICU-23262 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 22 Jul 2026 16:21:05 GMT ✔ Approvals: 2 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/64678#pullrequestreview-4910237836 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64678#pullrequestreview-4910813233 ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-12T18:27:40Z: https://ci.nodejs.org/job/node-test-pull-request/75801/ - Querying data for job/node-test-pull-request/75801/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/31640517938 |
Member
Author
|
Landed in 167768f |
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #64678 Fixes: #63041 Refs: https://unicode-org.atlassian.net/browse/ICU-23262 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63041
Refs: https://unicode-org.atlassian.net/browse/ICU-23262
This fixes a bug in ICU 78 whereby absent era data causes libicu to bail out of loading subsequent locale data, including month names. The associated bug is attached to the ICU 79 milestone, so this should be fixed in the next release.
The iso8601 calendar does not contain era names in CLDR 48, but due to an initialization quirk, other fields end up missing in DateTimeFormat output. This is now a much more noticeable issue since certain Temporal objects can only be DateTimeFormat-ed with the iso8601 calendar, and we have had multiple complaints regarding this.
Firefox and Chromium are floating ephemeral patches to the datafile to add the missing era data (https://crrev.com/c/7843156) to bypass this bug. We cannot patch the locale data in our build setup as we use the precompiled ICU data from the sources package, but we can patch out the initialization bug so that the other iso8601 calendar data is intact.
Patch: