url: align URLPatternInit with WebIDL - #64781
Conversation
|
Review requested:
|
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64781 +/- ##
==========================================
+ Coverage 90.28% 90.29% +0.01%
==========================================
Files 760 760
Lines 247137 247128 -9
Branches 46617 46607 -10
==========================================
+ Hits 223122 223142 +20
+ Misses 15493 15454 -39
- Partials 8522 8532 +10
π New features to boost your workflow:
|
Read URLPatternInit dictionary members in lexicographical order so getters and proxy traps observe the access sequence required by WebIDL. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Use sparse dictionary template values so URLPatternResult inputs only expose members present after WebIDL conversion. Emit present members in WebIDL order. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Commit Queue failed- Loading data for nodejs/node/pull/64781 β Done loading data for nodejs/node/pull/64781 ----------------------------------- PR info ------------------------------------ Title url: align URLPatternInit with WebIDL (#64781) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Archkon:url4 -> nodejs:main Labels c++, whatwg-url, author ready, needs-ci, commit-queue, whatwg-urlpattern Commits 2 - url: read URLPatternInit members in WebIDL order - url: omit absent URLPatternInit members from exec results Committers 1 - Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/64781 Fixes: https://github.com/nodejs/node/issues/64780 Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64781 Fixes: https://github.com/nodejs/node/issues/64780 Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- βΉ This PR was created on Mon, 27 Jul 2026 14:15:16 GMT β Approvals: 1 β - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64781#pullrequestreview-4860427489 β Last GitHub CI successful βΉ Last Full PR CI on 2026-08-05T02:24:28Z: https://ci.nodejs.org/job/node-test-pull-request/75497/ - Querying data for job/node-test-pull-request/75497/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD e04663a1ea..ab9afa9267 main -> origin/main β origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 576553e829 src: match cmd.exe case-insensitively in task runner - ab9afa9267 src: match cmd.exe case-insensitively in task runner -------------------------------------------------------------------------------- HEAD is now at ab9afa9267 src: match cmd.exe case-insensitively in task runner β Reset to origin/main - Downloading patch for 64781 From https://github.com/nodejs/node * branch refs/pull/64781/merge -> FETCH_HEAD β Fetched commits as abbf086f1c76..4bf5637103e9 -------------------------------------------------------------------------------- [main 250cb73dc2] url: read URLPatternInit members in WebIDL order Author: Archkon <180910180+Archkon@users.noreply.github.com> Date: Sat Jul 25 19:09:57 2026 +0800 2 files changed, 30 insertions(+), 6 deletions(-) [main 9be99ecc34] url: omit absent URLPatternInit members from exec results Author: Archkon <180910180+Archkon@users.noreply.github.com> Date: Sat Jul 25 19:24:00 2026 +0800 2 files changed, 28 insertions(+), 23 deletions(-) β Patches applied There are 2 commits in the PR. Attempting autorebase. (node:1515) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- url: read URLPatternInit members in WebIDL orderhttps://github.com/nodejs/node/actions/runs/31330750033 |
Fixes: #64780