Skip to content

url: align URLPatternInit with WebIDL - #64781

Closed
Archkon wants to merge 2 commits into
nodejs:mainfrom
Archkon:url4
Closed

url: align URLPatternInit with WebIDL #64781
Archkon wants to merge 2 commits into
nodejs:mainfrom
Archkon:url4

Conversation

@Archkon

@Archkon Archkon commented Jul 27, 2026

Copy link
Copy Markdown

Fixes: #64780

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
βœ… Project coverage is 90.29%. Comparing base (bb76938) to head (4bf5637).
⚠️ Report is 148 commits behind head on main.

Files with missing lines Patch % Lines
src/node_url_pattern.cc 50.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64781      +/-   ##
==========================================
+ Coverage   90.28%   90.29%   +0.01%     
==========================================
  Files         760      760              
  Lines      247137   247128       -9     
  Branches    46617    46607      -10     
==========================================
+ Hits       223122   223142      +20     
+ Misses      15493    15454      -39     
- Partials     8522     8532      +10     
Files with missing lines Coverage Ξ”
src/node_url_pattern.cc 83.37% <50.00%> (-0.35%) ⬇️

... and 32 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Archkon added 2 commits August 2, 2026 14:58
Read URLPatternInit dictionary members in lexicographical order so
getters and proxy traps observe the access sequence required by WebIDL.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Use sparse dictionary template values so URLPatternResult inputs only
expose members present after WebIDL conversion. Emit present members in
WebIDL order.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon

This comment was marked as spam.

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. whatwg-urlpattern labels Aug 5, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 9, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64781
βœ”  Done loading data for nodejs/node/pull/64781
----------------------------------- PR info ------------------------------------
Title      url: align URLPatternInit with WebIDL  (#64781)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Archkon:url4 -> nodejs:main
Labels     c++, whatwg-url, author ready, needs-ci, commit-queue, whatwg-urlpattern
Commits    2
 - url: read URLPatternInit members in WebIDL order
 - url: omit absent URLPatternInit members from exec results
Committers 1
 - Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64781
Fixes: https://github.com/nodejs/node/issues/64780
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64781
Fixes: https://github.com/nodejs/node/issues/64780
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Mon, 27 Jul 2026 14:15:16 GMT
   βœ”  Approvals: 1
   βœ”  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64781#pullrequestreview-4860427489
   βœ”  Last GitHub CI successful
   β„Ή  Last Full PR CI on 2026-08-05T02:24:28Z: https://ci.nodejs.org/job/node-test-pull-request/75497/
- Querying data for job/node-test-pull-request/75497/
βœ”  Build data downloaded
   βœ”  Last Jenkins CI successful
--------------------------------------------------------------------------------
   βœ”  No git cherry-pick in progress
   βœ”  No git am in progress
   βœ”  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   e04663a1ea..ab9afa9267  main       -> origin/main
βœ”  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 576553e829 src: match cmd.exe case-insensitively in task runner
 - ab9afa9267 src: match cmd.exe case-insensitively in task runner
--------------------------------------------------------------------------------
HEAD is now at ab9afa9267 src: match cmd.exe case-insensitively in task runner
   βœ”  Reset to origin/main
- Downloading patch for 64781
From https://github.com/nodejs/node
 * branch                  refs/pull/64781/merge -> FETCH_HEAD
βœ”  Fetched commits as abbf086f1c76..4bf5637103e9
--------------------------------------------------------------------------------
[main 250cb73dc2] url: read URLPatternInit members in WebIDL order
 Author: Archkon <180910180+Archkon@users.noreply.github.com>
 Date: Sat Jul 25 19:09:57 2026 +0800
 2 files changed, 30 insertions(+), 6 deletions(-)
[main 9be99ecc34] url: omit absent URLPatternInit members from exec results
 Author: Archkon <180910180+Archkon@users.noreply.github.com>
 Date: Sat Jul 25 19:24:00 2026 +0800
 2 files changed, 28 insertions(+), 23 deletions(-)
   βœ”  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:1515) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
url: read URLPatternInit members in WebIDL order

Read URLPatternInit dictionary members in lexicographical order so
getters and proxy traps observe the access sequence required by WebIDL.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64781
Fixes: #64780
Reviewed-By: Aviv Keller <me@aviv.sh>

[detached HEAD 929c8570ea] url: read URLPatternInit members in WebIDL order
Author: Archkon <180910180+Archkon@users.noreply.github.com>
Date: Sat Jul 25 19:09:57 2026 +0800
2 files changed, 30 insertions(+), 6 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
url: omit absent URLPatternInit members from exec results

Use sparse dictionary template values so URLPatternResult inputs only
expose members present after WebIDL conversion. Emit present members in
WebIDL order.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64781
Fixes: #64780
Reviewed-By: Aviv Keller <me@aviv.sh>

[detached HEAD b98a771a48] url: omit absent URLPatternInit members from exec results
Author: Archkon <180910180+Archkon@users.noreply.github.com>
Date: Sat Jul 25 19:24:00 2026 +0800
2 files changed, 28 insertions(+), 23 deletions(-)
Successfully rebased and updated refs/heads/main.

β„Ή Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/31330750033

@Archkon

This comment was marked as spam.

@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. whatwg-urlpattern

Projects

None yet

Development

Successfully merging this pull request may close these issues.

url: URLPatternInit dictionary conversion does not follow WebIDL semantics

4 participants