doc: report proper return type on urlPattern.test - #64831
Merged
nodejs-github-bot merged 2 commits intoAug 9, 2026
Conversation
Signed-off-by: bmuenzenmeyer <brian.muenzenmeyer@gmail.com>
nodejs-github-bot
added
doc
bmuenzenmeyer
commented
Jul 30, 2026
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
Contributor
Author
There was a problem hiding this comment.
noticed this should be in brackets
avivkeller
approved these changes
Jul 30, 2026
lpinca
approved these changes
Jul 30, 2026
avivkeller
added
the
author ready
jasnell
approved these changes
Aug 2, 2026
trivikr
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 45ecaad |
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: bmuenzenmeyer <brian.muenzenmeyer@gmail.com> PR-URL: #64831 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derived from nodejs/doc-kit#953 - chipping away at these via intentionally small chunks - I may adapt the approach to do it module-by-module
Validated with a local running of doc-kit: