src: include declaration header in threadsafe COW inl - #64858
Closed
Archkon wants to merge 2 commits into
Closed
Conversation
Ensure node_threadsafe_cow-inl.h can be included independently and follows the header inclusion convention documented in src/README.md Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
nodejs-github-bot
added
c++
Include node_mutex.h explicitly so node_threadsafe_cow.h does not depend on the include order for the RwLock definition. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64858 +/- ##
==========================================
+ Coverage 90.16% 90.19% +0.03%
==========================================
Files 746 746
Lines 242760 243122 +362
Branches 45765 45954 +189
==========================================
+ Hits 218875 219289 +414
+ Misses 15375 15336 -39
+ Partials 8510 8497 -13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure node_threadsafe_cow-inl.h can be included independently and follows the header inclusion convention documented in src/README.md