Skip to content

src: constrain COW forwarding constructors - #64861

Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:cow3
Closed

src: constrain COW forwarding constructors#64861
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:cow3

Conversation

@Archkon

@Archkon Archkon commented Jul 31, 2026

Copy link
Copy Markdown

Exclude the wrapper type from the forwarding constructors so that non-const lvalue copies select the copy constructor.

Exclude the wrapper type from the forwarding constructors so that
non-const lvalue copies select the copy constructor.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (c8e2a82) to head (efc5fa9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64861      +/-   ##
==========================================
+ Coverage   90.16%   90.17%   +0.01%     
==========================================
  Files         746      746              
  Lines      242760   242768       +8     
  Branches    45765    45759       -6     
==========================================
+ Hits       218875   218907      +32     
+ Misses      15375    15347      -28     
- Partials     8510     8514       +4     
Files with missing lines Coverage Δ
src/node_threadsafe_cow.h 100.00% <ø> (+8.33%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants