test: use libuv clock for immediate queue test - #64889
Closed
trivikr wants to merge 1 commit into
Closed
Conversation
Use getLibuvNow() when waiting for the timeout to expire. Date.now() may have different precision from libuv's clock, causing the immediate queue to run an extra iteration on platforms with coarse timers. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
nodejs-github-bot
added
needs-ci
trivikr
added
flaky-test
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64889 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 746 746
Lines 242849 242849
Branches 45771 45771
==========================================
- Hits 218906 218895 -11
Misses 15438 15438
- Partials 8505 8516 +11 🚀 New features to boost your workflow:
|
pimterry
approved these changes
Aug 3, 2026
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
trivikr
added
the
commit-queue
Collaborator
panva
removed
the
commit-queue
panva
pushed a commit
that referenced
this pull request
Aug 8, 2026
Use getLibuvNow() when waiting for the timeout to expire. Date.now() may have different precision from libuv's clock, causing the immediate queue to run an extra iteration on platforms with coarse timers. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #64889 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue Reviewed-By: Tim Perry <pimterry@gmail.com>
Member
|
Landed in 73236f3 |
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Use getLibuvNow() when waiting for the timeout to expire. Date.now() may have different precision from libuv's clock, causing the immediate queue to run an extra iteration on platforms with coarse timers. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #64889 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue
Use
getLibuvNow()when waiting for the timeout to expire.Date.now()may have different precision from libuv's clock, causing the immediate queue to run an extra iteration on platforms with coarse timers.Assisted-by: codex:gpt-5.6-sol