Skip to content

src: avoid task runner crash on inaccessible bin paths - #64905

Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner2
Closed

src: avoid task runner crash on inaccessible bin paths#64905
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner2

Conversation

@Archkon

@Archkon Archkon commented Aug 1, 2026

Copy link
Copy Markdown

Use the error_code overload of std::filesystem::is_directory() when probing node_modules/.bin, allowing package.json lookup to continue when the directory cannot be accessed.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2026
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (73236f3) to head (71936e7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64905   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         759      759           
  Lines      248295   248296    +1     
  Branches    46863    46859    -4     
=======================================
+ Hits       224242   224251    +9     
- Misses      15460    15470   +10     
+ Partials     8593     8575   -18     
Files with missing lines Coverage Δ
src/node_task_runner.cc 89.38% <100.00%> (+0.05%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Use the error_code overload of std::filesystem::is_directory() when
probing node_modules/.bin, allowing package.json lookup to continue when
the directory cannot be accessed.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon

This comment was marked as spam.

@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants