src: override inherited task runner environment - #64906
Closed
Archkon wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64906 +/- ##
==========================================
+ Coverage 90.28% 90.30% +0.01%
==========================================
Files 760 760
Lines 247061 247065 +4
Branches 46592 46586 -6
==========================================
+ Hits 223058 223108 +50
+ Misses 15491 15441 -50
- Partials 8512 8516 +4
🚀 New features to boost your workflow:
|
Filter inherited NODE_RUN_SCRIPT_NAME and NODE_RUN_PACKAGE_JSON_PATH before adding the current task values. This prevents duplicate environment entries during nested node --run invocations. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Member
|
@Archkon ... I need to ask you to please stop pinging people to look at your PRs. It is becoming quite excessive and noisy. If a PR has been open a month without any reviews or discussion a ping like this would be fine, but you have been pinging for PRs that are only open a few days. It's unnecessary and disruptive. /cc @nodejs/moderation |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter inherited NODE_RUN_SCRIPT_NAME and NODE_RUN_PACKAGE_JSON_PATH before adding the current task values. This prevents duplicate environment entries during nested node --run invocations.