Skip to content

src: stop package search at empty package.json - #64918

Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner7
Closed

src: stop package search at empty package.json#64918
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner7

Conversation

@Archkon

@Archkon Archkon commented Aug 1, 2026

Copy link
Copy Markdown

Represent package contents with std::optional so a successfully read empty file is distinct from a missing file. This prevents node --run from falling back to scripts in a parent package.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2026
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (73236f3) to head (b3b89cf).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64918   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         759      759           
  Lines      248295   248298    +3     
  Branches    46863    46863           
=======================================
+ Hits       224242   224245    +3     
- Misses      15460    15467    +7     
+ Partials     8593     8586    -7     
Files with missing lines Coverage Δ
src/node_task_runner.cc 91.71% <100.00%> (+2.38%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Represent package contents with std::optional so a successfully read
empty file is distinct from a missing file. This prevents node --run
from falling back to scripts in a parent package.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants