src: stop package search at empty package.json - #64918
Closed
Archkon wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64918 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 759 759
Lines 248295 248298 +3
Branches 46863 46863
=======================================
+ Hits 224242 224245 +3
- Misses 15460 15467 +7
+ Partials 8593 8586 -7
🚀 New features to boost your workflow:
|
Represent package contents with std::optional so a successfully read empty file is distinct from a missing file. This prevents node --run from falling back to scripts in a parent package. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent package contents with std::optional so a successfully read empty file is distinct from a missing file. This prevents node --run from falling back to scripts in a parent package.