lib: use validateArray for array arguments - #64959
Merged
Merged
Conversation
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
avivkeller
approved these changes
Aug 2, 2026
panva
approved these changes
Aug 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64959 +/- ##
==========================================
- Coverage 90.30% 90.29% -0.01%
==========================================
Files 760 760
Lines 247154 247140 -14
Branches 46613 46609 -4
==========================================
- Hits 223181 223164 -17
- Misses 15443 15454 +11
+ Partials 8530 8522 -8
🚀 New features to boost your workflow:
|
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
MattiasBuelens
approved these changes
Aug 2, 2026
Collaborator
daeyeon
added
the
commit-queue
Collaborator
|
Landed in e6fa5bf |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces manual
ArrayIsArraychecks that throwERR_INVALID_ARG_TYPEwith the sharedvalidateArrayhelper, following #39774.The thrown error is unchanged in all seven spots:
validateArraythrowsERR_INVALID_ARG_TYPE(name, 'Array', value)under the same!ArrayIsArray(value)condition, and the defaultminLength = 0makes its length check a no-op. Existing tests already pin the message, e.g.test-tls-set-default-ca-certificates-error.jsassertsThe "certs" argument must be an instance of Array.In
lib/internal/streams/iter/{push,broadcast}.jsthe checks stay synchronous:writev/writevSyncthrew before reaching any async path, andvalidateArraythrows synchronously too.