stream: use validateBuffer for BYOB reader view - #65046
Merged
nodejs-github-bot merged 1 commit intoAug 13, 2026
Merged
Conversation
The same check is already spelled validateBuffer(view, 'view') in ReadableStreamBYOBRequest.respondWithNewView(), and the thrown error is unchanged. Signed-off-by: greenhead <shren0812@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65046 +/- ##
==========================================
- Coverage 90.30% 90.29% -0.01%
==========================================
Files 759 759
Lines 247612 247602 -10
Branches 46686 46681 -5
==========================================
- Hits 223604 223579 -25
- Misses 15460 15462 +2
- Partials 8548 8561 +13
🚀 New features to boost your workflow:
|
Contributor
Author
|
The |
daeyeon
approved these changes
Aug 9, 2026
jasnell
approved these changes
Aug 9, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65046 ✔ Done loading data for nodejs/node/pull/65046 ----------------------------------- PR info ------------------------------------ Title stream: use validateBuffer for BYOB reader view (#65046) Author greenhead <shren0812@gmail.com> (@greenheadHQ) Branch greenheadHQ:readablestream-validate-buffer -> nodejs:main Labels author ready, needs-ci, commit-queue, web streams Commits 1 - stream: use validateBuffer for BYOB reader view Committers 1 - greenhead <shren0812@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65046 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65046 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 05 Aug 2026 12:51:50 GMT ✔ Approvals: 2 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65046#pullrequestreview-4891279202 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65046#pullrequestreview-4892848785 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/31602140325 |
Contributor
Author
|
@daeyeon It looks like the queue stopped because Jenkins CI hadn’t run yet. When you have a chance, could you help trigger the full CI? Thanks for looking into this! 🫡 |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
|
Landed in 1d9d49c |
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
The same check is already spelled validateBuffer(view, 'view') in ReadableStreamBYOBRequest.respondWithNewView(), and the thrown error is unchanged. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #65046 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadableStreamBYOBReader.prototype.read()open-codes the check thatvalidateBufferperforms, whileReadableStreamBYOBRequest.prototype.respondWithNewView()a few hundred lines above already callsvalidateBuffer(view, 'view')for the same argument. Both buildERR_INVALID_ARG_TYPEfrom the same name and type list, so the rejection is unchanged.No new test:
readable-byte-streams/general.any.jsalready coversread()with a non-view argument.