doc: add missing ESM examples to DEP0202 and DEP0207 - #65047
Open
ChocoChip0519 wants to merge 1 commit into
Open
doc: add missing ESM examples to DEP0202 and DEP0207#65047ChocoChip0519 wants to merge 1 commit into
ChocoChip0519 wants to merge 1 commit into
Conversation
DEP0202 and DEP0207 each have two consecutive cjs code blocks with no corresponding mjs block, breaking the cjs/mjs pairing convention used elsewhere in this file. Signed-off-by: Taeuk Ha <tomcat0519@naver.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
deprecations
avivkeller
approved these changes
Aug 5, 2026
avivkeller
added
the
author ready
AugustinMauroy
approved these changes
Aug 5, 2026
aduh95
reviewed
Aug 11, 2026
Comment on lines
+4698
to
+4706
| ```mjs | ||
| // Deprecated | ||
| server.on('stream', (stream) => { | ||
| stream.on('aborted', () => { | ||
| // Stream was closed while the writable was still open. | ||
| }); | ||
| }); | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
What value does this bring, your just duplicating the same code
aduh95
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEP0202 and DEP0207 each have two consecutive cjs code blocks with no corresponding mjs block, breaking the cjs/mjs pairing convention used elsewhere in this file.