Skip to content

process: stop _kill on missing arguments - #65072

Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process5
Closed

process: stop _kill on missing arguments#65072
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process5

Conversation

@Archkon

@Archkon Archkon commented Aug 6, 2026

Copy link
Copy Markdown

Return immediately after throwing ERR_MISSING_ARGS so process._kill() does not coerce missing arguments or call uv_kill().

Return immediately after throwing ERR_MISSING_ARGS so process._kill()
does not coerce missing arguments or call uv_kill().

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (c18fd90) to head (c74b5da).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65072      +/-   ##
==========================================
- Coverage   90.31%   90.30%   -0.01%     
==========================================
  Files         759      759              
  Lines      247646   247647       +1     
  Branches    46697    46703       +6     
==========================================
- Hits       223654   223642      -12     
- Misses      15463    15469       +6     
- Partials     8529     8536       +7     
Files with missing lines Coverage Δ
src/node_process_methods.cc 88.93% <100.00%> (+0.40%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr added the process Issues and PRs related to the process subsystem. label Aug 7, 2026
@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants