doc: fix util signal exit code link - #65124
Conversation
|
@avivkeller I could swear that malformed internal links used to get picked up by the old tooling? |
We haven't moved to the new linter yet π everything now is the old tooling (lint wise). The new linter will catch these, when we finalize it following RenderATL. |
|
The commit lint check is failing because the sign-off is missing. Please amend it with |
Signed-off-by: Dayun <dlekdbs6530@gmail.com>
Commit Queue failed- Loading data for nodejs/node/pull/65124 β Done loading data for nodejs/node/pull/65124 ----------------------------------- PR info ------------------------------------ Title doc: fix util signal exit code link (#65124) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch dayun6530:ossca-week3 -> nodejs:main Labels child_process, doc, author ready, commit-queue Commits 1 - doc: fix util signal exit code link Committers 1 - Dayun <dlekdbs6530@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65124 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65124 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Fri, 07 Aug 2026 21:10:00 GMT β Approvals: 3 β - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65124#pullrequestreview-4887550801 β - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65124#pullrequestreview-4889483253 β - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65124#pullrequestreview-4891212939 β Last GitHub CI successful βΉ Green GitHub CI is sufficient -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 3c46dbdc09..ad3432189c main -> origin/main β origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 711323da5a tools: bump js-yaml from 4.2.0 to 4.3.1 in /tools/lint-md - ad3432189c tools: bump js-yaml from 4.2.0 to 4.3.1 in /tools/lint-md -------------------------------------------------------------------------------- HEAD is now at ad3432189c tools: bump js-yaml from 4.2.0 to 4.3.1 in /tools/lint-md β Reset to origin/main - Downloading patch for 65124 From https://github.com/nodejs/node * branch refs/pull/65124/merge -> FETCH_HEAD β Fetched commits as 5f1ef0a95376..7982446647dc -------------------------------------------------------------------------------- The previous cherry-pick is now empty, possibly due to conflict resolution. If you wish to commit it anyway, use:https://github.com/nodejs/node/actions/runs/31401397043 |
|
Superseded by d846ffd |
Fix the broken link to
util.convertProcessSignalToExitCode()in the child process documentation.Tests:
make lint-md