Skip to content

doc: fix util signal exit code link - #65124

Closed
dayun6530 wants to merge 1 commit into
nodejs:mainfrom
dayun6530:ossca-week3
Closed

doc: fix util signal exit code link#65124
dayun6530 wants to merge 1 commit into
nodejs:mainfrom
dayun6530:ossca-week3

Conversation

@dayun6530

Copy link
Copy Markdown

Fix the broken link to util.convertProcessSignalToExitCode() in the child process documentation.

Tests: make lint-md

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Aug 7, 2026
@Renegade334

Copy link
Copy Markdown
Member

@avivkeller I could swear that malformed internal links used to get picked up by the old tooling?

@avivkeller

avivkeller commented Aug 8, 2026

Copy link
Copy Markdown
Member

@avivkeller I could swear that malformed internal links used to get picked up by the old tooling?

We haven't moved to the new linter yet πŸ˜… everything now is the old tooling (lint wise).

The new linter will catch these, when we finalize it following RenderATL.

@daeyeon

daeyeon commented Aug 8, 2026

Copy link
Copy Markdown
Member

The commit lint check is failing because the sign-off is missing. Please amend it with git commit --amend -s and force-push. You can verify it locally before pushing with npx core-validate-commit --no-validate-metadata HEAD.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>
@daeyeon daeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 9, 2026
@avivkeller avivkeller added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 9, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65124
βœ”  Done loading data for nodejs/node/pull/65124
----------------------------------- PR info ------------------------------------
Title      doc: fix util signal exit code link (#65124)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     dayun6530:ossca-week3 -> nodejs:main
Labels     child_process, doc, author ready, commit-queue
Commits    1
 - doc: fix util signal exit code link
Committers 1
 - Dayun <dlekdbs6530@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65124
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65124
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Fri, 07 Aug 2026 21:10:00 GMT
   βœ”  Approvals: 3
   βœ”  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65124#pullrequestreview-4887550801
   βœ”  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65124#pullrequestreview-4889483253
   βœ”  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65124#pullrequestreview-4891212939
   βœ”  Last GitHub CI successful
   β„Ή  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   βœ”  No git cherry-pick in progress
   βœ”  No git am in progress
   βœ”  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   3c46dbdc09..ad3432189c  main       -> origin/main
βœ”  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 711323da5a tools: bump js-yaml from 4.2.0 to 4.3.1 in /tools/lint-md
 - ad3432189c tools: bump js-yaml from 4.2.0 to 4.3.1 in /tools/lint-md
--------------------------------------------------------------------------------
HEAD is now at ad3432189c tools: bump js-yaml from 4.2.0 to 4.3.1 in /tools/lint-md
   βœ”  Reset to origin/main
- Downloading patch for 65124
From https://github.com/nodejs/node
 * branch                  refs/pull/65124/merge -> FETCH_HEAD
βœ”  Fetched commits as 5f1ef0a95376..7982446647dc
--------------------------------------------------------------------------------
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch main
Your branch is up to date with 'origin/main'.

You are currently cherry-picking commit 7982446647.
(all conflicts fixed: run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
(use "git add <file>..." to include in what will be committed)
labels.json
output

nothing added to commit but untracked files present (use "git add" to track)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/31401397043

@aduh95

aduh95 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Superseded by d846ffd

@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants