src: shave about 20 bytes off each TLSWrap instance - #65144
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/make_tls_wrap_smaller
branch
from
August 8, 2026 20:35
f70abd2 to
542fa03
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65144 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 760 760
Lines 248525 248531 +6
Branches 46894 46890 -4
=======================================
+ Hits 224488 224495 +7
+ Misses 15469 15467 -2
- Partials 8568 8569 +1
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
pimterry
approved these changes
Aug 9, 2026
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
tniessen
reviewed
Aug 9, 2026
tniessen
left a comment
tniessen
left a comment
Member
There was a problem hiding this comment.
IIRC, g++/LLVM/MSVC support bool bit fields. Is there a reason for switching to uint8_t?
Member
Author
|
@tniessen ... mere force of habit! I'd forgotten that bool bit fields were supported ;-) Updated |
By shifting from individual bool fields to a packed struct we can save 20 bytes per TLSWrap instance Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/make_tls_wrap_smaller
branch
from
August 10, 2026 13:55
542fa03 to
87f319b
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
tniessen
approved these changes
Aug 11, 2026
jasnell
added a commit
that referenced
this pull request
Aug 12, 2026
By shifting from individual bool fields to a packed struct we can save 20 bytes per TLSWrap instance Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #65144 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Member
Author
|
Landed in 3ad9427 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By shifting from individual bool fields to a packed struct we can save 20 bytes per TLSWrap instance