src: make the options structs smaller with packed bits - #65145
Open
jasnell wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/make-options-structs-smaller
branch
from
August 8, 2026 21:24
5d00d67 to
1039041
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65145 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 760 760
Lines 248525 248653 +128
Branches 46894 46889 -5
==========================================
+ Hits 224488 224587 +99
- Misses 15469 15475 +6
- Partials 8568 8591 +23
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
While the Options objects are not a significant overhead, they still waste a few hundred bytes due to sloppy definition and alignment issues. Tighten it up and shave off a couple hundred wasted bytes. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/make-options-structs-smaller
branch
from
August 10, 2026 13:53
1039041 to
25d1a1a
Compare
Collaborator
Qard
approved these changes
Aug 12, 2026
Qard
left a comment
Qard
left a comment
Member
There was a problem hiding this comment.
Generally LGTM. Just with a question:
Is the EnvironmentOptions rearrangement an ABI break? Or is that private? I forget if that is exposed is any way in the embedding API.
Member
Author
|
If that's even a minor possibility I've no problem making this a semver-major... Ultimately, however, I don't believe it's an issue. There's no direct use of node_options.h from node.h |
jasnell
added
the
author ready
lemire
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the Options objects are not a significant overhead, they still waste a few hundred bytes due to sloppy definition and alignment issues. Tighten it up and shave off a couple hundred wasted bytes.