net: ignore stale lookup callbacks after reconnect - #65239
Open
wehamed wants to merge 1 commit into
Open
Conversation
A DNS lookup started before Socket.destroy() can complete after the same Socket has been reconnected. Since reconnecting sets `connecting` back to true, the stale lookup callback can act on the new connection lifecycle and start another connect on its handle. Track the socket connection generation across destroy boundaries and ignore stale lookup and autoSelectFamily callbacks from an earlier generation. Signed-off-by: Hamed Elaraby <qef0@hotmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #55519
A DNS lookup started before
Socket.destroy()can complete after thesame socket has been reconnected. Because reconnecting sets
connectingback totrue, the stale callback can pass the existingguard and initiate another connection using the new lifecycle's handle,
resulting in errors such as
EALREADY.This change tracks the socket connection generation across destroy
boundaries. Lookup and autoSelectFamily callbacks captured by an older
generation are ignored after the socket is reused.
The regression test uses a local server and controlled lookup callbacks
to reproduce the stale-callback ordering deterministically.
Tests:
EALREADYgit diff --check