events: accept boolean options in removeEventListener - #65245
Open
lazerg wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65245 +/- ##
==========================================
- Coverage 90.31% 90.29% -0.02%
==========================================
Files 760 760
Lines 248637 248637
Branches 46942 46929 -13
==========================================
- Hits 224556 224516 -40
- Misses 15475 15520 +45
+ Partials 8606 8601 -5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removeEventListener()readcaptureoff the options object only, so the boolean shorthandtarget.removeEventListener('foo', fn, true)was flattened tocapture: falseand never matched a listener registered with capture on.addEventListener()already handles the boolean form, so the two went out of sync and the listener stayed attached. Browsers remove it.Fixes #65244