Skip to content

Generate worker types in prepare script - #1001

Open
flakey5 wants to merge 1 commit into
mainfrom
flakey5/20260811/conf
Open

Generate worker types in prepare script#1001
flakey5 wants to merge 1 commit into
mainfrom
flakey5/20260811/conf

Conversation

@flakey5

@flakey5 flakey5 commented Aug 11, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
flakey5 requested a review from a team as a code owner August 11, 2026 21:04
@flakey5 flakey5 mentioned this pull request Aug 11, 2026

@MattIPv4 MattIPv4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need src/env.ts, doesn't wrangler types generate typings for that as well now?

@flakey5

flakey5 commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

It does but then I don't think we can have the inline comments on the vars

@MattIPv4

MattIPv4 commented Aug 11, 2026

Copy link
Copy Markdown
Member

It does but then I don't think we can have the inline comments on the vars

Can't we place those in the wrangler config, or is the intellisense what you're concerned about?

(Would be a cool upstream wrangler PR to read jsonc comments from the line above an env var and use that to generate a typedoc comment)

@flakey5

flakey5 commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Yeah intellisense, but that's really just a personal preference. Also since we have multiple environments would we be duplicating the comments per env in the wrangler file?

@MattIPv4

Copy link
Copy Markdown
Member

I would probably put the comments in the top-level vars definition and not in the environment-specific definitions, but also totally fine w/ keeping the ts file if that's easier 👍

@flakey5 flakey5 added auto-merge Ready to automatically merge after being open for 48 hours force ci Force tests & linting to be ran on a PR labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Ready to automatically merge after being open for 48 hours force ci Force tests & linting to be ran on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants