Generate worker types in prepare script - #1001
Conversation
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
MattIPv4
left a comment
There was a problem hiding this comment.
Do we need src/env.ts, doesn't wrangler types generate typings for that as well now?
|
It does but then I don't think we can have the inline comments on the vars |
Can't we place those in the wrangler config, or is the intellisense what you're concerned about? (Would be a cool upstream wrangler PR to read jsonc comments from the line above an env var and use that to generate a typedoc comment) |
|
Yeah intellisense, but that's really just a personal preference. Also since we have multiple environments would we be duplicating the comments per env in the wrangler file? |
|
I would probably put the comments in the top-level vars definition and not in the environment-specific definitions, but also totally fine w/ keeping the ts file if that's easier 👍 |
No description provided.