Skip to content

Fix slang global session leak in ShaderCooker #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pursche merged 1 commit into from
Aug 11, 2026
Merged

Fix slang global session leak in ShaderCooker #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/ShaderCooker/ShaderCooker/ShaderCompiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ namespace ShaderCooker
}
else if (_stageInfo.stage == Stage::COMPILATION)
{
ShaderCooker::SlangBridge slangBridge(_sourceDirPath);

for (Shader& shader : _shaders)
{
if (!shader.hasResolvedIncludes)
Expand All @@ -269,8 +271,6 @@ namespace ShaderCooker
continue;
}

ShaderCooker::SlangBridge slangBridge(_sourceDirPath);

// Figure out the actual permutations
u32 numPermutationGroups = static_cast<u32>(shader.permutationGroups.size());

Expand Down
2 changes: 1 addition & 1 deletion Source/ShaderCooker/ShaderCooker/SlangBridge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace ShaderCooker

SlangBridge::~SlangBridge()
{

delete static_cast<SlangBridgeData*>(_data);
}

void SlangBridge::AddDefine(const std::string& name, const std::string& value)
Expand Down
Loading