feat(task-mcp-service): move MCP server to services/ with lib/src split - #231
Open
alex-nsheaps[bot] wants to merge 2 commits into
Open
feat(task-mcp-service): move MCP server to services/ with lib/src split#231alex-nsheaps[bot] wants to merge 2 commits into
alex-nsheaps[bot] wants to merge 2 commits into
Conversation
…SKILL.md Line 89 referenced nsheaps/agents/docs/journal/2026/05/16/managing-tasks-example.md which does not exist. Replaced with generic label per Nate review comment. Co-Authored-By: Agent Alex Picard <alex-nsheaps[bot]@users.noreply.github.com>
…with lib/src split
Addresses Nate review comment on agents#216: "make the mcp server its own pr.
Make it follow repo patterns. Make the service entry point in
/services/task-mcp-service and use lib/ and package/ etc to properly abstract
re-usable bits."
Changes:
- plugins/claude-code/task-utils/mcp/ → services/task-mcp-service/
- Generic engine extracted to services/task-mcp-service/lib/:
- lib/git-helper.ts: tryGitAutoCommit, CrudOperation, GitAutoCommitResult
(no task-specific buildCommitMessage — moved to src/store.ts)
- lib/store-base.ts: generic StoreBase<T>, gitRepoRoot, resolveStoreRoot
(parameterized for env-var name + store path)
- Task-specific code in services/task-mcp-service/src/:
- src/store.ts: TaskRecord, TaskStatus, TaskStore extends StoreBase,
buildCommitMessage (chore(tasks):), resolveStoreRoot wrapper
- src/tasks.ts: TaskManager lifecycle engine
- src/validation-steps.ts: unchanged
- src/server.ts: MCP tool registrations (jsonResult/errorResult)
- Plugin wiring updated:
- plugins/claude-code/task-utils/.mcp.json: launch path → services/
- plugins/claude-code/task-utils/hooks/hooks.json: prewarm path → services/
- mise.toml: build-task-mcp + test-task-mcp tasks point to services/
- Tests updated with corrected import paths
Co-Authored-By: Agent Alex Picard <alex-nsheaps[bot]@users.noreply.github.com>
alex-nsheaps Bot
added a commit
that referenced
this pull request
Jun 9, 2026
…-service (#231) The MCP server is now its own PR (agents#231) at services/task-mcp-service/ with a lib/src split (generic store-base + git-helper in lib/, task-specific code in src/). This PR retains only the plugin + hooks. - Remove plugins/claude-code/task-utils/mcp/ entirely - Update .mcp.json launch path → services/task-mcp-service/launch.sh - Update hooks.json prewarm path → services/task-mcp-service/prewarm.sh - Update mise.toml build-task-mcp / test-task-mcp → services/task-mcp-service/ Co-Authored-By: Agent Alex Picard <alex-nsheaps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the task-utils MCP server out of agents#216 into its own PR, per Nate's review comment: "make the mcp server its own pr. Make it follow repo patterns. Make the service entry point in /services/task-mcp-service and use lib/ and package/ etc to properly abstract re-usable bits."
Stacked on agents#216 — merge #216 first, then this.
Changes
plugins/claude-code/task-utils/mcp/removed; server now lives atservices/task-mcp-service/services/task-mcp-service/lib/— generic reusable engine (no task-specific assumptions):lib/git-helper.ts:tryGitAutoCommit,CrudOperation,GitAutoCommitResult— callable by a future ticket-mcp-service with its own commit messagelib/store-base.ts:StoreBase<T>(generic flat-YAML CRUD),gitRepoRoot,resolveStoreRoot(parameterized env-var + store-path)services/task-mcp-service/src/— task-specific layer:src/store.ts:TaskRecord,TaskStatus,TaskStore extends StoreBase<TaskRecord>,buildCommitMessage(chore(tasks):), 2-argresolveStoreRootwrappersrc/tasks.ts:TaskManagerlifecycle engine (0-or-1 in_progress, validation-steps gating)src/validation-steps.ts: unchangedsrc/server.ts: MCP tool registrations (task_create/update/list/get),jsonResult/errorResult.mcp.jsonlaunch path +hooks.jsonprewarm path →services/mise.toml:build-task-mcp/test-task-mcptasks point toservices/task-mcp-service/Reuse path for future ticket-mcp-service
A future ticket-mcp-service provides its own
TicketRecordtype, env-var name, store sub-path, andbuildCommitMessage(chore(tickets):), then reuseslib/git-helper.ts+lib/store-base.tsverbatim. No extraction needed beyond what's here.Test plan
mise run build-task-mcpcompiles successfully fromservices/task-mcp-service/mise run test-task-mcp— all unit + integration tests pass.mcp.json+hooks.jsonpaths resolve correctly after plugin installbun tsc --noEmitclean inservices/task-mcp-service/🤖 Generated with Claude Code