Fix SIGHUP - #4113
Open
End-rey wants to merge 3 commits into
Open
Conversation
Build replacement gRPC servers and bind newly added endpoints before stopping existing servers. This keeps the current Public API available when the new TLS configuration is invalid or a new endpoint is occupied. Track the configuration snapshot associated with running servers. Update it only after a successful reload, so a failed rebind is retried on the next SIGHUP instead of reusing a stopped server. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Validate the newly read configuration before applying it. Invalid configuration now aborts reload before services are modified. Notify systemd that the node is ready after both successful and failed reload attempts, preventing a unit from remaining in the reloading state after an error. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Return attribute parsing errors to the configuration reloader instead of terminating the process. Restore the previous node attributes when the updated attributes cannot be parsed. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
July 31, 2026 15:45
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4113 +/- ##
==========================================
- Coverage 27.20% 27.18% -0.03%
==========================================
Files 676 676
Lines 46227 46273 +46
==========================================
+ Hits 12576 12577 +1
- Misses 32437 32483 +46
+ Partials 1214 1213 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
Create an issue for neofs-testcases to test these scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some issues when adding a new configuration to gRPC.