Revert "feat(auth): add authorization_request_params to OpenID4VCI requestCredential API (#4333)"#4349
Closed
reinkrul wants to merge 1 commit into
Closed
Revert "feat(auth): add authorization_request_params to OpenID4VCI requestCredential API (#4333)"#4349reinkrul wants to merge 1 commit into
reinkrul wants to merge 1 commit into
Conversation
reinkrul
requested review from
gerardsn,
stevenvegt and
woutslakhorst
as code owners
Contributor
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (1)
🛟 Help
|
reinkrul
added a commit
that referenced
this pull request
Jul 6, 2026
Profiles (see previous commit) replace the raw authorization_request_params escape hatch: issuers that need extra authorization parameters get a named, curated profile instead of callers spelling out parameters themselves. Removes the field, its handling, and its tests, folding in the change from #4349.
Member
Author
|
Superseded by #4340 — folded this revert directly into the profiles branch instead of landing it separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4333.
Reverts merged commit
fa89c810, which added theauthorization_request_paramsfield to the OpenID4VCIrequestCredentialAPI. Instead, we'll introduces profiles: #4340Affected files:
auth/api/iam/openid4vci.go+auth/api/iam/openid4vci_test.goauth/api/iam/generated.go,e2e-tests/browser/client/iam/generated.go(generated)docs/_static/auth/v2.yaml(OpenAPI spec)No later commits on
masterdepend on it, so the revert applies cleanly.Assisted by AI