fix(lsp): attach dartls to the buffer that requested it - #530
Merged
Conversation
`M.attach()` validates the path of the current buffer, but `vim.lsp.start()` was called without `opts`, so the client attached to whichever buffer happened to be current when the callback ran. With `flutter_lookup_cmd` configured that callback is scheduled off a job's output, so switching buffers right after opening a dart file attached dartls to the wrong buffer and left the dart file unattached. Pass the captured `bufnr` through, and bail out if the buffer is gone by the time the callback runs. Also cache the paths resolved via `flutter_lookup_cmd`, matching the `fvm` and `flutter_path` branches. That branch was the only one leaving `cached_paths` unset, so it re-ran the external lookup command on every `attach()` - now once per `FileType` event since #527.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M.attach()validates the path of the current buffer, butvim.lsp.start()was called withoutopts, so the client attached to whichever buffer happened to be current when the callback ran. Withflutter_lookup_cmdconfigured that callback is scheduled off a job's output, so switching buffers right after opening a dart file attached dartls to the wrong buffer and left the dart file unattached.Pass the captured
bufnrthrough, and bail out if the buffer is gone by the time the callback runs.Also cache the paths resolved via
flutter_lookup_cmd, matching thefvmandflutter_pathbranches. That branch was the only one leavingcached_pathsunset, so it re-ran the external lookup command on everyattach()- now once perFileTypeevent since #527.