[IMP] empty - #5203
Open
arpi-odoo wants to merge 4 commits into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
Steps to reproduce: - Open an employee record with no contract start date set. - Observe the Contract section in the form view. - The "New Contract" button is visible when it should not be. Cause: The `button_new_contract` widget declaration in `hr_employee_views.xml` lacked an `invisible` attribute checking for `contract_date_start`. Solution: Add `invisible="not contract_date_start"` to the `button_new_contract` widget in `hr_employee_views.xml` so that the button is hidden when no contract start date is present. Task: 6443374
Steps to reproduce: - Open the Time Off app. - Create a new time off request. - Click on the "Time Off Type" dropdown field. - A traceback occurs (TypeError: gt expected 2 arguments, got 1). Cause: In `hr_work_entry_type.py`, the `_search_virtual_remaining_leaves` method's internal `is_valid` function evaluates `op(work_entry_type.virtual_remaining_leaves)` with only one argument instead of passing the comparison value as the second argument. Solution: Pass `value` as the second argument to `op()` in `_search_virtual_remaining_leaves` (i.e. `op(work_entry_type.virtual_remaining_leaves, value)`). Task: 6446513
…_time_off_type-tomic [FIX] hr_holidays: fix search on virtual_remaining_leaves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.