[IMP] hr: moved permit_no & expiration to parent class hr_version - #5220
Open
sdemeesterde wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-samde, it needs to be retargeted before it can be merged. |
SaraBriki
reviewed
Aug 5, 2026
SaraBriki
left a comment
SaraBriki
left a comment
There was a problem hiding this comment.
Great work 🙂 ! I left a few comments for you to check.
| work_permit_expiration_date = fields.Date('Work Permit Expiration Date', groups="hr.group_hr_user", tracking=True) | ||
| has_work_permit = fields.Binary(string="Work Permit", groups="hr.group_hr_user") | ||
| work_permit_scheduled_activity = fields.Boolean(default=False, groups="hr.group_hr_user") | ||
| work_permit_name = fields.Char('work_permit_name', compute='_compute_work_permit_name', groups="hr.group_hr_user") |
There was a problem hiding this comment.
What about the rest of the work permit fields 🤔
(If the Binary one causes issues, just leave it as is)
The work permit number of an employee was not versioned, making it impossible to store 2 different values (in case of a renewal). Solution: Move the permit_no field to parent class hr_version, along with linked field work_permit_expiration_date, and the linked computed field work_permit_name. Task: 6446323
sdemeesterde
force-pushed
the
master-hr-onboarding-task_make_permit_no_versioned-samde
branch
from
August 6, 2026 15:51
e2c7a2a to
38a8ce4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work permit number of an employee was not versioned, making it impossible to store 2 different values (in case of a renewal).
Solution: Move the permit_no field to parent class hr_version, along with linked field work_permit_expiration_date.
Task: 6446323