[FIX] hr_holidays: Fix error when creating a leave - #5224
Merged
HashemKhaled merged 1 commit intoAug 7, 2026
Merged
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-amgom, it needs to be retargeted before it can be merged. |
HashemKhaled
requested changes
Aug 6, 2026
HashemKhaled
left a comment
HashemKhaled
left a comment
There was a problem hiding this comment.
LGTM! but since this is a bugfix task, we should add a test to be sure that it won't break again 🙂
HashemKhaled
requested changes
Aug 6, 2026
HashemKhaled
left a comment
HashemKhaled
left a comment
There was a problem hiding this comment.
The commit message of bug fix tasks should include the steps to reproduce, reason and the solution
amgom-odoo
force-pushed
the
master-time-off-fix-type-error-amgom
branch
2 times, most recently
from
August 7, 2026 08:26
805cd5a to
f214dae
Compare
HashemKhaled
requested changes
Aug 7, 2026
HashemKhaled
left a comment
HashemKhaled
left a comment
There was a problem hiding this comment.
One small comment and we are ready to go
Fix a missing argument error when creating a leave and selecting work entry type.
Steps to reproduce:
1. Create a new leave type with:
- `requires_allocation` checked.
- `time_off_selectable` checked.
- `allow_negative` unchecked.
2. Create a new allocation for this leave type with a positive number of days for an employee.
3. Create a new leave request with this leave type and the allocated employee.
Task: 6449776
amgom-odoo
force-pushed
the
master-time-off-fix-type-error-amgom
branch
from
August 7, 2026 09:53
f214dae to
6d91457
Compare
HashemKhaled
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a missing argument error when creating a leave and selecting work entry type.
Steps to reproduce:
requires_allocationchecked.time_off_selectablechecked.allow_negativeunchecked.Task: 6449776