[WIP] Implementation of estate module - #1372
Conversation
YassinWalid
left a comment
There was a problem hiding this comment.
Thanks for the incredible work. I have added an initial review, with some comments on the PR, and other general comments below.
For the naming convention of models, the record id in xml, or the id & name of records in the security access csv file, you can have a look at the coding guidelines.
Don't forget the empty line at the end of each file, to have better code traceability.
05ba125 to
ae57e2b
Compare
YassinWalid
left a comment
There was a problem hiding this comment.
Thanks for your work. I left a couple of minor comments on the PR, as well as a general one below.
Don't forget the empty lines at the end of all files.
YassinWalid
left a comment
There was a problem hiding this comment.
Thanks for your work. Just one small comment.
In the commits where you introduced the new modules, the commit title should start with [ADD] <module_name>: message

Implementation of Estate module.
Tasks