fix(billing): send post-checkout users to the org billing page#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Stripe checkout
successUrlpointed at/workspaces/__SLUG__/settings, which is not a route in this scaffold (workspace and settings pages live under/organizations/$orgSlug/...). Any app scaffolded from this template redirected paying users to a Page Not Found immediately after subscribing.Fix the root-cause scaffold so future apps do not inherit the 404: point
successUrlat/organizations/__SLUG__/billing, which exists and shows the now-active subscription. Aether substitutes__SLUG__with the real org slug before redirecting.Matches the fix already shipped in fractal-app (#60); sibling apps (moment, blossom, arbor, channel, manifold, synapse) get the same fix in parallel.
Details
src/components/pricing/PriceCard.tsx.__SLUG__(the org slug) fills the/organizations/<slug>/...path correctly.Testing
knip,biome check,tsc --noEmit./organizations/$orgSlug/billingroute exists in the scaffold.