Add VisiMusic plugin - #463
Open
kmturley wants to merge 1 commit into
Open
Conversation
Corrected display name capitalization ("VisiMusic" per the project's
own README/branding). Fixed the Windows architecture from x32 to x64:
fetch.ts misread the "win_x86" filename token, but the binary's own
folder path (Contents/x86_64-win) and `file` output confirm it's a
64-bit DLL. Verified the macOS binary is arm64-only via lipo, matching
the filename.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Plugin author notification: @darilin98 — your plugin has been submitted to the Open Audio Stack registry. Please review this PR and let us know if the metadata (name, description, tags, files) is correct. To see a full list of all currently added plugins, click here. |
Member
Author
|
VirusTotal has flagged this binary: |
|
Hello @kmturley, these vendor security check fails are most likely due to the fact that the binary has not been properly signed on macOS as I do not own an Apple Developer ID. The plugin includes ffmpeg which should not be statically compiled with the plugin, so it is instead included in the Frameworks/ subdirectory in the bundle and the .vst3 binary has been adjusted to look for ffmpeg there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contents/x86_64-win) andfileoutput confirm it's a 64-bit DLLlipothat the macOS binary is arm64-only, matching the filenameCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com